search

SibylLab / Program-Wars

A web-based educational card game for teaching basic concepts of computer programming and cybersecurity
https://program-wars.firebaseapp.com
GNU General Public License v3.0
16 stars 4 forks source link

Bonus scores #598

Closed maimoona-bashir closed 4 years ago

maimoona-bashir commented 4 years ago

Fixes #596

Overview of changes

-Variable and Repeat Bonuses updated -WinnersModal Updated -Clean System & Defensive Programmer fixed

Reviewer: @johnanvik

strinsberg commented 4 years ago

This needs to be merged into addMalwareCards-#534 and not into master. It may be possible for @maimoona-bashir to edit the request and change the target branch, but we may need to create a new one.

This will also make the checks failing unnecessary because we will not be merging directly into master. I will fix the unit tests we broke by changing the Objectives.js to work with new cards.

strinsberg commented 4 years ago

Changes were merged into addMalwareCards-#534 instead.