Collapse `ReportItem` and recategorize reports

SichangHe / internet_route_verification

RPSLyzer: Parse Routing Policy Specification Language from IRR and compare BGP routes against it

MIT License

1 stars 0 forks source link

Collapse `ReportItem` and recategorize reports #66

Closed SichangHe closed 11 months ago

SichangHe commented 11 months ago

Fix #65.

Flattening ReportItem makes little difference programmatically, but it greatly simplifies shifting the categories of the reports and helps reduce ReportItem's size from 5 to 4 words.

[x] UnknownFilter is an RPSL error.
[x] More intuitive naming for SkipFBad, etc..
[x] Reorder AnyReport to flow unidirectionally ok → skip → unrecorded → meh.
[x] Report::UnrecordedImport, etc. and the "unrecorded" case in AllReport and AnyReport.
[x] Remove skipping skipped.

SichangHe commented 11 months ago

This PR, if merged, will make many current stats stale. They will need to be redone.

SichangHe commented 11 months ago

PartialOrd seems like a good idea at first, until you consider:

This part of the code needs to be absolutely fast so slice::sort is undesired.
The inner value of each case has to be accessed using a match anyway. We could have another function that does that, but then the code is not really simplified then.

I am currently satisfied with listing all possibilities and making them clear. Let's just have it like this for now.