search

SickHub / ark-server-charts

A helm chart for an ARK Survival Evolved Cluster
GNU General Public License v3.0
13 stars 4 forks source link

Remove volumeName if not using existing pv #19

Closed DebakelOrakel closed 2 years ago

DebakelOrakel commented 2 years ago

Removes the volumeMode from pvc if not using an existing pv.

DrPsychick commented 2 years ago

You're writing VolumeMode but the PR removes VolumeName - I guess that is just a mistake in the PR name/comment.

This PR would break my use case: I use the "default" VolumeNames and make sure these exist. I could switch to explicitly defining the VolumeName in existingVolume to get rid of the else case.

Out of curiosity: How are you using persistence with this chart?

DebakelOrakel commented 2 years ago

I'm still in the process of setting up the ark cluster.
But for storage i use either ceph or topolvm (for local storage).

DrPsychick commented 2 years ago

Closed, resolved by #20