search

SickheadGames / Torsion

The TorqueScript IDE for Torque engine games and mods.
http://www.sickheadgames.com
Other
38 stars 37 forks source link

Replace CMarkup with TinyXML2 #1

Open tomspilman opened 8 years ago

tomspilman commented 8 years ago

Torsion used an XML parser/writer library called CMarkup which is not open source:

http://www.firstobject.com/dn_markstlplat.htm

I've omitted that from this code base and we need to replace it with something equivalently simple, easy to use, and open source.

I suggest we use TinyXML2:

https://github.com/leethomason/tinyxml2

This fix is critical to getting Torsion running again.

tomspilman commented 8 years ago

Another option now that I think of it is contacting the developers of CMarkup and seeing if they would allow us to use it as part of this open source project.

Could be they go for that and i can add the original code back in.

I will try reaching out to them tomorrow and report back.

dottools commented 8 years ago

Doesn't hurt to ask. I haven't used CMarkup before so I don't know what advantages it has over TinyXML or TinyXML2.

tomspilman commented 8 years ago

Back when I wrote it CMarkup was the best XML library out there. No clue now.

Azaezel commented 8 years ago

Fars it goes, the t3d side's already bundling https://github.com/GarageGames/Torque3D/tree/development/Engine/lib/tinyxml so yeah, a switch over would cut down on the dependency hunting...

tomspilman commented 8 years ago

Well we still want to maintain our own dependencies in this repo separate from T3D/2D, but there might be some benefit to having XML parser compatibility with the engines.

But really if the CMarkup guys let us use their product here i'd rather do that because it works fine without any code changes to Torsion. So less chance of bugs to start with.

Azaezel commented 8 years ago

Fair enough. Do look forward to seeing where this goes at any rate.

dchau28 commented 8 years ago

Any update on this? What version of CMarkup is being used by Torsion?

tomspilman commented 8 years ago

Any update on this?

No update... I personally don't have time to go integrate TinyXML2.

What version of CMarkup is being used by Torsion?

It was a really old version... 7.1. It was very robust when I used it originally and I doubt anything would be broken by using the newest release. The only issue with it is that it isn't open source.

yurembo commented 8 years ago

What version of MarkupSTL did you use?

velteyn commented 6 years ago

Im working to remove CMarkup , have you got any documentation for it so to ease the transition ? Im trying thinyxml

tomspilman commented 6 years ago

The latest CMarkup docs are here...

http://www.firstobject.com/dn_markupmethods.htm

I don't think the API changed all that much from back then... but it could be a little different.

velteyn commented 6 years ago

tkz ;)

velteyn commented 6 years ago

Ok I'm done with the porting, but I have problems in compiling wxWidgets in VS 2015... It seams that it is outdated version 2.6.3... Can you help me ? Also excuse me for the messy code... I had lot of old code comments around because I want to have the old functions handy to understand the exact meaning. This should be held on a separate branch until perfected.

Shockwave-X769 commented 6 years ago

Ok I'm done with the porting, but I have problems in compiling wxWidgets in VS 2015... It seams that it is outdated version 2.6.3... Can you help me ? Also excuse me for the messy code... I had lot of old code comments around because I want to have the old functions handy to understand the exact meaning. This should be held on a separate branch until perfected.

Any news about this? And do you have a separate branch now?

velteyn commented 5 years ago

Hello, I put on 2 pull requests now, I have only 24 linker problems to overcome, I need a little help, thanks !!

storm32600 commented 3 years ago

You can make visual studio use an older toolset, but still get the features of the updated visual studio 2019. Like load the 2012 toolchain and it should compile just fine, I think that was the visual studio version originally. BTW: Hi everyone I'm StOrM3, I have a huge project planned for T3D, updating the renderers to use DX12 and Vulkan. I'm basically going to attempt to merge wicked engine which is also open source with T3D. Fingers crossed.

velteyn commented 3 years ago

Ah this is an abandoned project. I'm with Godot Engine guys now !! I supported Torque community years ago.. Now with Godot out is meaningless to support this

Shockwave-X769 commented 3 years ago

You can make visual studio use an older toolset, but still get the features of the updated visual studio 2019. Like load the 2012 toolchain and it should compile just fine, I think that was the visual studio version originally. BTW: Hi everyone I'm StOrM3, I have a huge project planned for T3D, updating the renderers to use DX12 and Vulkan. I'm basically going to attempt to merge wicked engine which is also open source with T3D. Fingers crossed.

did you ever work further on Torsion?

dickensas commented 1 year ago

I would recommend libxml2 which you can install inside MSYS2 from there you can invoke CMake, libxml2 also comes under MIT license