search

SickheadGames / Torsion

The TorqueScript IDE for Torque engine games and mods.
http://www.sickheadgames.com
Other
38 stars 37 forks source link

wx update and cmake #12

Closed ghost closed 8 years ago

ghost commented 8 years ago

This is progress for updating wx and I also have a cmake. It doesn't build yet but I've got it down to some linker errors.

Not ready yet.

ghost commented 8 years ago

I've upgraded to the latest version of CMarkup for now until I or someone else makes the switch to tinyxml.

The Markup.cpp and Markup.h files should be placed in the code/Torsion directory before cmake configuration and generation.

dottools commented 8 years ago

There's so many things wrong with this PR I'm not going to bother commenting each and every little thing. So many operations are commented out entirely instead of fixed, and so on. PRs should only be done when they're actually completed. Now don't get me wrong there's a huge amount of great work on getting it compliant with the latest wxWidgets version. However it's still very much an incomplete mess.

ghost commented 8 years ago

Who said PRs are only for completed works? Is that in the github bible? This PR is tracking my branch. That's what it's for. I'll rebase later.

tomspilman commented 8 years ago

Hi @blackwc.

I think the wxWidgets port work is great... but i will not merge CMake or CMarkup.

I want to have VS solutions and projects in this repo and not a CMake build script. When I discussed build scripting in https://github.com/SickheadGames/Torsion/issues/4 it was simply about the glue between the steps and not project generation. It was mean for replacing this:

https://github.com/SickheadGames/Torsion/blob/master/msbuild.proj

Not for automating project generation.

As For CMarkup I omitted it from the repo on purpose. The license in the zip clearly stipulates it is evaluation purposes only. We're not evaluating it... I did that 10 years ago... it is great and i'd love to use it, but it is not open source licensed. I wrote https://github.com/SickheadGames/Torsion/issues/1 specifically for these reasons. That said if you want to reach out to the CMarkup developers and ask about using it in open source that would be great.

Keeping a WIP PR like this is fine... it doesn't bother anyone and lets us see progress. Just in the end lets rebase and flatten some of the commits.

ghost commented 8 years ago

Understood. I'll look into it.

ghost commented 8 years ago

Torsion now gives me a bad taste in my mouth. I'm closing this PR but leaving the branch up.

tomspilman commented 8 years ago

@blackwc - That is fine. Good luck with your projects.