search

Sicos1977 / IFilterTextReader

A reader that gets text from different file formats through the IFilter interface
Other
55 stars 38 forks source link

IFilterTextReader Project converted to .NET Standard 2.0 #27

Closed mgeramb closed 6 years ago

mgeramb commented 6 years ago

I have converted the Project to .NET Standard 2.0 so it can be used for .NET Core and classic .NET Projects

Sicos1977 commented 6 years ago

I don't think that this project will work on any other machine than the one that is running Windows. Under the hood IFilters are used and this is something that only exists in Windows.... not to be blunt but what is the point of converting this to .NET Standard 2.0 to support other operating systems?

mgeramb commented 6 years ago

You are right, it will only work on windows but it can use the .NET Core runtime and the classic runtime

mgeramb commented 6 years ago

But the Integration build process must be changed also...

Sicos1977 commented 6 years ago

If you put it like that then you have a good point. But I still think it is better to just upgrade to .NET 4.6.1 since that is the same version that .NET standard 2.0 uses. This way the project can be added in a .NET Standard 2.0 project but it will always give a warning that is possible will not work on other operating systems.

Sicos1977 commented 6 years ago

This article explains when or when not to use .NET Standard (core) --> https://stackify.com/net-core-vs-net-framework/