search

Sicos1977 / IFilterTextReader

A reader that gets text from different file formats through the IFilter interface
Other
55 stars 38 forks source link

Missing filter return code? #45

Closed Spiralis closed 4 years ago

Spiralis commented 4 years ago

Thanks for maintaining this library.

I have some old ifilter-code that I am replacing by using your library instead.

It uses a filter return code that your library does not handle it seems:

/// <summary>
/// The docfile has been corrupted
/// </summary>
STG_E_DOCFILECORRUPT = 0x80030109,

Is that a possible return type? If so, would it be a candidate to implement?

Sicos1977 commented 4 years ago

Sure but I never have seen this return code as an IFilter one. I think it is part of reading office files

Sicos1977 commented 4 years ago

It is also not mentioned as a valid return code for the GetChunk, GetText or GetValue methods.

https://docs.microsoft.com/en-us/windows/win32/api/filter/nf-filter-ifilter-getchunk

I can add it but I don't know if it will do anything. I also don't know how to test it.

Sicos1977 commented 4 years ago

No response, closed

Spiralis commented 4 years ago

Thanks for the feedback. I am guessing that it was "badly injected" in our code by the original author :)

Sicos1977 commented 4 years ago

I'm guessing you are the author? ;-)

Spiralis commented 4 years ago

Ha-ha. I am actually not. Made before my days in the company, and I have no idea who made it. We changed to git about 7 years ago, and the history before then is lost. And the code is really old. I think it is at least 10-15 years old.

And, I'd rather use your library instead of trying to create this myself. Happy to upgrade :)

Sicos1977 commented 4 years ago

Haha no problems. If you run into something then just make a new issue.