Inline images seem to not be treated as such

[melchor629]

Describe the bug Inline images are not treated as inline from version 4.4.6.

To Reproduce

1. Generate an .msg with an inline image, with HTML inside.

Expected behavior The attachment of the inline image is treated as inline.

Additional context It seems that between 4.4.5 and 4.4.6 something has changed that now the inline images are not treated as such. If I use 4.4.5, everything works fine. Upgrading to 4.4.6 or newer, it stops working.

In the example I've got, the HTML contains the following image:

But then, the attachment has the IsInline set to false:

Maybe related PR I've found: https://github.com/Sicos1977/MSGReader/pull/307

[Cyril12740]

I have changed companies and I no longer use your package to read emails.

Do you need an email reproducing my error or that of melchor629?

[Sicos1977]

I need one from @melchor629

[melchor629]

Hello, sorry for the slow response :(

I've built a small email sample and small code to reproduce. Hope it helps:

using MsgReader.Outlook;

System.Text.Encoding.RegisterProvider(System.Text.CodePagesEncodingProvider.Instance);
using var stream = File.OpenRead(@"..\..\test.msg");
using Storage.Message msg = new Storage.Message(stream);
foreach (var attachment in msg.Attachments)
{
    if (attachment is Storage.Attachment attachmentCasted)
    {
        Console.WriteLine($"{attachmentCasted.FileName}: IsInline={attachmentCasted.IsInline} Hidden={attachmentCasted.Hidden}");
    }
}

test.msg.zip

Results with 4.4.5:

Results with 4.4.6 (same as in 4.4.16):

[Sicos1977]

Seems to be working fine now

[melchor629]

Cool, thanks for your work :)

[M8anu]

This thread is awesome seal of approval content, bending

[Sicos1977]

?

[zeOxx]

@Sicos1977 sorry to resurrect this, but it seems like this issue has returned. this is from 3.4.1 (yes, this is an old version...) this is from 5.2.2

the email i tested with: image test.msg.zip