search

Sid200026 / studious-train

A collection of Android apps
1 stars 10 forks source link

BookDetails #18

Open Richaagrawal314 opened 4 years ago

Richaagrawal314 commented 4 years ago

I'd like to make an app in Kotlin which will fetch details about a book like author,description and price from Google Books API. Later I can also add features like link to preview if available etc.

Sid200026 commented 4 years ago

Sure go ahead @Richaagrawal314

Richaagrawal314 commented 4 years ago

@Sid200026 #19 I have created the pull request. When you review it, can you please add the "hacktoberfest-accepted" label to it, without that this PR would not be eligible for hactoberfest.

Sid200026 commented 4 years ago

@Sid200026 #19 I have created the pull request. When you review it, can you please add the "hacktoberfest-accepted" label to it, without that this PR would not be eligible for hactoberfest.

Done

Richaagrawal314 commented 4 years ago

@Sid200026 Also add "hacktoberfest" topic on your repository. Right Now, this repository is not classified for hacktoberfest. https://hacktoberfest.digitalocean.com/hacktoberfest-update Thanks. :D

Richaagrawal314 commented 4 years ago

Sorry, I closed it by mistake.

Richaagrawal314 commented 4 years ago

@Sid200026 #19 I have created the pull request. When you review it, can you please add the "hacktoberfest-accepted" label to it, without that this PR would not be eligible for hactoberfest.

Done

@Sid200026 Can you also add topic "hacktoberfest" to the repository in the about section ; top-right on your screen just when you open the repository. It's showing me ineligible PR for hacktoberfest. (Sorry that I'm pestering you.)

Sid200026 commented 4 years ago

Check now. The below message is from HacktoberFest's official website

Do pull requests have to be accepted/merged?

No. They will still count unless they are spam, irrelevant, or labelled as invalid or spam by a maintainer, as long as they are marked as ready-for-review. (Draft pull requests are not counted.)

Richaagrawal314 commented 4 years ago

Check now. The below message is from HacktoberFest's official website

Do pull requests have to be accepted/merged?

No. They will still count unless they are spam, irrelevant, or labelled as invalid or spam by a maintainer, as long as they are marked as ready-for-review. (Draft pull requests are not counted.)

Yaa, it worked. Thanks!🙂

Sid200026 commented 4 years ago

Ok. Upload a preview and I'll merge it