search

SiddharthBharadwaj / prettyrecon-cli

PrettyRecon-cli is an unofficial cli client for PrettyRecon. This tool can be used to trigger various tasks on prettyrecon as well as fetch output of those tasks/scans.
9 stars 1 forks source link

Task Pending Loop issue #2

Closed Sicks3c closed 2 years ago

Sicks3c commented 2 years ago

Summary

Hello dude Thank you so much for this small api, I have tried it today for first time and I encoureted an issue where I have task pending loop when I run it

Steps to reproduce:

PoC

Screen Shot 2022-06-01 at 13 44 00

N.B: Login in into my web interface I can't find the job in pending or anywhere

Sicks3c commented 2 years ago

and I think the issue resides in this part of the code https://github.com/SiddharthBharadwaj/prettyrecon-cli/blob/main/main.py#L40 Where you start the loop when a Task is on Pending which doesn't block normally unless it's a CustomSubsScan

Sicks3c commented 2 years ago

Alright I have fixed it by removint the job function from the main.py and it worked perfectly

I suggest you may want to add that function again only for CustomsubScan since they can be more than 1 instance at a time and it will be great if you add another function for it since it not included yet in this overflow it should take a list of subdomains even 10K and split them to 300 each and Sleep for 1-2 hours and check again and run when the task is not pending

I hope you got the idea

Regards

SiddharthBharadwaj commented 2 years ago

Hey @Sicks3c ! The issue should now be fixed after cdc1b55d1292f267d92f2731dc3b1a1b3378e57a. Can you please confirm the same?

About CustomsubScan. Yes, I have got the idea and after this job check update it should be little easier to implement. I will be adding that function whenever I am able to get some time.

Thank You

Sicks3c commented 2 years ago

Hello @SiddharthBharadwaj

Thank you the commit did the job Can't wait for the CustomsubScan

Regards