Closed Macleykun closed 1 year ago
ya wanna use github and/or dockerhub to host the image?
Latest ci/cd compiled!
I realised when pushing to a public image, that the size is way to big (530MB>) This next build should be way smaller, it's also tested locally.
https://hub.docker.com/r/macley/omnisette/tags now it's about less then 40MB :)
berfore merging, please add these variables with the appropiated values username: username the above is what you change in the ci/cd file itself password: ${{ secrets.GITHUB_TOKEN }} the above is one you set as a secret in the ci/cd as a variable!
@JJTech0130 or @Dadoum, @naturecodevoid asked if either one of you would like to review this PR, as he's prioritizing unstable features right now. It's ok to use debian for now, he'll one day rework this to make it work on alpine. If there are any questions, do let me know :)
@JJTech0130 i though i responded on your reviews, but it seems github though i wanted to create another review...
@Macleykun Did you ever fix it? I don't see responses?
@Macleykun Did you ever fix it? I don't see responses?
Can you see my reviews? I hoped to respond to yours but GitHub just created a new review for some reason
sorry for the commits last and second last will be good. Change the repository to: sideStore/omnisette-server instead of mines. Any other questions :P ?
please do test :) if i might come to it, i can also add a ci/cd