SideStore / omnisette-server

An HTTP server wrapper for omnisette. Supports both V1 (Provision) and V3 of anisette servers.
64 stars 93 forks source link

add docker support and compile steps #2

Closed Macleykun closed 1 year ago

Macleykun commented 1 year ago

please do test :) if i might come to it, i can also add a ci/cd

Macleykun commented 1 year ago

ya wanna use github and/or dockerhub to host the image?

Macleykun commented 1 year ago

Latest ci/cd compiled!

Macleykun commented 1 year ago

I realised when pushing to a public image, that the size is way to big (530MB>) This next build should be way smaller, it's also tested locally.

https://hub.docker.com/r/macley/omnisette/tags now it's about less then 40MB :)

Macleykun commented 1 year ago

berfore merging, please add these variables with the appropiated values username: username the above is what you change in the ci/cd file itself password: ${{ secrets.GITHUB_TOKEN }} the above is one you set as a secret in the ci/cd as a variable!

Macleykun commented 1 year ago

@JJTech0130 or @Dadoum, @naturecodevoid asked if either one of you would like to review this PR, as he's prioritizing unstable features right now. It's ok to use debian for now, he'll one day rework this to make it work on alpine. If there are any questions, do let me know :)

Macleykun commented 1 year ago

@JJTech0130 i though i responded on your reviews, but it seems github though i wanted to create another review...

JJTech0130 commented 1 year ago

@Macleykun Did you ever fix it? I don't see responses?

Macleykun commented 1 year ago

@Macleykun Did you ever fix it? I don't see responses?

Can you see my reviews? I hoped to respond to yours but GitHub just created a new review for some reason

Macleykun commented 1 year ago

See https://github.com/SideStore/omnisette-server/pull/2/files/1b60c521ede71afa8c1eaf9179395e42e51d4545

Macleykun commented 1 year ago

sorry for the commits last and second last will be good. Change the repository to: sideStore/omnisette-server instead of mines. Any other questions :P ?