Closed f1shy-dev closed 1 year ago
ignore commits, due to an accidental mistake in the commit config I was committing new features to the same branch, these have been reverted, the only change is the CNAME file.
closing.
If we need to delete this, I'll do it on a non weird history single commit instead.
but that being said, the cname
file is harmless and usually recommended for jekyll themes and stuff.
In other words, it's not the reason the website is broken, it's DNS settings between github/cloudflare and the registrar.
I have other sites working in the same manner, for provenance, we have provenance-emu.app, wiki.provenance-emu.com and more subdomains works just fine with cloudflare, github pages+ namescheap as the registrar..
I have to dig into what's fucked up on this but in the mean time, I turned off cloudflare proxying and it's working now.
We really don't need cloudflare proxying since github already uses cloudflare as their CDN
Yeah fair enough for now.
Also, sorry about the commit history, didn't realise I was working on the PR branch and got confused with reverting it.
This PR removes the CNAME file because as specified in the GitHub Pages documentation, it is not required when deploying from actions.
Instead, this needs to be done in CloudFlare DNS, which should be configured according to the GH documentation (Can also be A record, but CNAME flattening as shown here should also work):
After that, in the Github Pages settings for this repo, the custom domain needs to be set to
sidestore.io
(I did it with my own subdomain seen in the image for testing), and the source needs to be set to Github Actions@JoeMatt please can you do this (I believe you have access to CloudFlare for the domain) (this should #9)
Also, on this repo can we set the redesign to the default branch and change the
main
branch to a different name? And can we rename the repo tosidestore.io
orsidesite
as it makes more sense