search

Sidoine / Ovale

An add-on for World of Warcraft that displays icons based on scripts
MIT License
46 stars 46 forks source link

Unholy Death Knight Rotation #709

Open Bloodhaunt74 opened 4 years ago

Bloodhaunt74 commented 4 years ago

I keep getting a recommendation for Death Coil without enough Runic Power. As RP requires a builder there is likely an issue.

Build Level 15: All Will Serve Level 25: Bursting Sores Level 30: Death's Reach Level 35: Soul Reaper Level 40: Death Pact Level 45: Unholy Pact Level 50: Army of the Damned

Sidoine commented 4 years ago

It's how the simulationcraft script is written. It won't ask you to cast a spender if apocalypse is not on cooldown, but maybe you want to keep it for a better moment. There are several scripts that have similar problems, I need to find a solution.

Ophidon commented 4 years ago

What I do is add another icon, one where it shows the action if I am pooling resources for cds, one for where I'm not. And then split ae into pooling/not pooling icons as well, if needed for the given spec. I tried just using a single icon and a 'use_cds' checkbox toggle, and turning it on and off mid-fight via hotkey, but that's a bit too fiddly.

johnnylam88 commented 3 years ago

I think it's worth creating a separate repository of the SimulationCraft profiles used to generate the default Ovale scripts. The repository can maintain a vendor branch for the unmodified profiles directly copied from SimulationCraft and the master branch can include modifications to allow for better translation into an Ovale script. I had done this with Ovale back in Warlords of Draenor.

It's possible to just directly patch the default Ovale scripts after they are imported from SimC, but it's much easier to modify the profiles themselves.

johnnylam88 commented 3 years ago

I believe this is improved with pullup #768 which has some support for checking whether the UDK's ghouls are active.