search

Sidoine / Ovale

An add-on for World of Warcraft that displays icons based on scripts
MIT License
46 stars 46 forks source link

feat: track Eclipse state directly in Ovale #952

Closed johnnylam88 closed 3 years ago

johnnylam88 commented 3 years ago

Track Eclipse state directly in Ovale and avoid needing special handling in scripts, including Eclipse buffs triggered by spell casts.

This fixes ticket #794.

johnnylam88 commented 3 years ago

This pullup with require the tstolua dependency to be bumped to fix the issue of bumping up against the upvalue limit.

johnnylam88 commented 3 years ago

This pullup should also fix tickets #757 and #766. I've tested the default script against the target dummies successfully.

johnnylam88 commented 3 years ago

This pullup includes a commit to hand-modify the generated script for balance druid, so the scripts don't need to be regenerated for a new release until the new importsimc is ready.