search

Sidsector9 / the-language-game

https://sidsector9.github.io/the-language-game/
1 stars 0 forks source link

feat/TLG-27: Reset Button is ambiguous #35

Closed CacheMeOwside closed 4 years ago

CacheMeOwside commented 4 years ago

Closes #27

Sidsector9 commented 4 years ago

Whenever a feature needs to be added, always check if it can purely be done using HTML or CSS. JavaScript should be the last option.

When you consider using JavaScript, before importing a library make sure if you can implement it on your own.

See the following issue:

Screenshot 2020-05-16 at 8 24 53 PM

The import cost of ReactTooltip is 8.5K, more than React itself. This will increase the script execution time and Javascript being a render-blocking resource, it will affect page load time.

The focus should be maintain the JS asset size as small as possible.

Try adding a title attribute here and see if it works.

CacheMeOwside commented 4 years ago

Screenshot (202)

Screenshot of "Reset cycle" tooltip

Sidsector9 commented 4 years ago

Closing in favour of #36