search

SiebelsTim / hack-sublime

Hack's typechecker & autocompletion inside Sublime Text
30 stars 4 forks source link

Fixed error parsing #10

Closed roguehedgehog closed 9 years ago

roguehedgehog commented 9 years ago

The plugin can now parse hacklang's new error message format. I have also added the error messages to the status bar.

SiebelsTim commented 9 years ago

This actually still works because of line 41 (https://github.com/SiebelsTim/hack-sublime/pull/10/files#diff-59e638def82185938b2b37dd5e49cd2bL41). We pass --from sublime, so we get the old formatting.

But I just noticed, I don't pass this argument when trying over ssh. Is that the problem you ran into? That would be an easy fix.

Also I think at some point we should use the --json option to retrieve the data.

roguehedgehog commented 9 years ago

Yes I was using it over ssh.

Also I think at some point we should use the --json option to retrieve the data.

I actually tried it with the json option and it returned no response. That might have more to do with ssh on Windows though; it worked fine when I logged in and ran the command directly.

SiebelsTim commented 9 years ago

Thanks for taking your time on this! :)

I pushed a fix so we use --from on ssh as well.