search

SiebelsTim / hack-sublime

Hack's typechecker & autocompletion inside Sublime Text
30 stars 4 forks source link

Fix highlighting errors over ssh #13

Closed david-collingwood closed 9 years ago

david-collingwood commented 9 years ago

Thought I might just give this a go. I'm using the "hack_ssh_folder" value to turn hh_client's filename into a relative url. I'm not sure how bullet-proof this solution is, but it seemed to do the trick for me.

SiebelsTim commented 9 years ago

I like it! Hopefully I have enough time tonight to test it.

david-collingwood commented 9 years ago

I'm not sure whether this was something you were intending on implementing or not, but I found that if I had not previously spawned the hh_server, that upon saving, the application would hang while the server was being started. So I've just refactored the code a little bit to run "hh_client" in a separate thread. Let me know what you think :)

SiebelsTim commented 9 years ago

Yeah... I noticed this some time ago. I really really like having this asynchronous.

I just returned back home and I need a little time to touch up for some things. This will take a few days, sorry! I'll get to it asap.

SiebelsTim commented 9 years ago

Love it! merged it.