Closed lalitpatel closed 4 years ago
Looks good to me!
I do have a different proposal for the button's behaviour and would like your opinion on it:
The benefits I see with this:
Thanks!
Your suggestion for displaying the icon and tooltip to offer to switch to the other theme is the ideal if there are just two states. I implemented the way it is now because there were three states and I didn't want to use a combination of buttons like we have for Language switcher since the choice of states are more or less expected / obvious.
My rationale for keeping a third 'Auto' state:
Ok! I did not think about OSes changing the setting based on the time of day, but only about users changing the setting manually. In that case it makes sense to have the AUTO
option.
Maybe we can still improve the tooltip a bit so it conveys what will happen when you click. We could add a text like "Click to toggle Dark mode setting" :thinking:
Maybe we can still improve the tooltip a bit so it conveys what will happen when you click. We could add a text like "Click to toggle Dark mode setting" 🤔
How about: "Current scheme: AUTO. Click to change" or "Current scheme: AUTO. Click to toggle"
How about: "Current scheme: AUTO. Click to change" or "Current scheme: AUTO. Click to toggle"
I would go with "Current colour scheme: AUTO. Click to change"
I have made a minor change to the text by adding the call to action in brackets. Hope that is okay.
Current colour scheme: {{scheme}} (click to change)
I have also extracted the scheme names for translation.
I have also added a css transition effect for an ease in effect while switching color schemes. Looks nice to me. Pls check and let me know how you like it.
I like I click merge :yellow_heart:
Summary
Many of the streamers use a Dark background for their overlay / interfaces. Having a dark theme would make the UI seamlessly integrate with their overlay.
Fixes: #41
Implementation
Notes
Screenshots