search

SiegeEngineers / aoe2cm2

Captains Mode for Age of Empires II
https://aoe2cm.net
51 stars 25 forks source link

Replace Button Set with Tabs in Preset Creator #95

Closed lalitpatel closed 2 years ago

lalitpatel commented 2 years ago

Before

before

After

after

URL Hash

Also provide and ability to preselect a civ set based on the URL hash so we can add different Create Preset buttons for different editions. Example:

https://aoe2cm.net/preset/create#aoe2
https://aoe2cm.net/preset/create#aoe3
https://aoe2cm.net/preset/create#aoe4
HSZemi commented 2 years ago

This is so obvious once you're shown the solution. Thanks!

There are two things still to improve I think.

The first one concerns dark mode: Is it supposed to look like this? grafik

The second one seems to be a data management issue: If you open any option apart from the aoe2 one directly via the link instead of navigating to it on-site, or if you just press F5 on those options, nothing is selected or the list of custom options is empty, instead of having the single pre-filled option.

HSZemi commented 2 years ago

The fixed version has been integrated with 939ef5fb71c379c217d1479bdec19aece2188d2b (and also 3ee697fbd52ba9fc30426c8d186c97853cd91039).

If necessary, we can have a look at the dark mode thing separately.