fix: increases opacity for cross (for colorblinds)

[maxpou]

Hey, I was watching a stream from rlyknght. He somehow complained about the cross not being visible for coloublinds.

If we add +30% opacity, it gets better.

Before / after:

Before / after: (in Chrome > emulate vision deficiencies > Protanopia) - upgrades like thumbring were barely noticeable.

Btw thanks for this app I love it <3

[simonsan]

I don't think this fixes the problem, but just makes it less bad. Would be nice to have a mode for it that switches to a high contrast mode or something. Or even adding more accessibility options overall.

[HSZemi]

But less bad is good, right? 11 And having a default that already is accessible is better than needing to flick an accessibility switch first in my opinion. I do have another idea that I would like to test first though

[HSZemi]

Pulling the crosses slightly bigger so they protrude outside of the image area and giving them a light red border? :thinking:

[simonsan]

I'm asking myself? Does it need to be red? Couldn't it be something like a gradient or just a more neutral colour?

We could chose another colour palette for that for example as default: https://davidmathlogic.com/colorblind/#%23F7B100

#F7B100 seems like a somewhat good choice to me?

If you scroll down on that page there are also recommended palettes under Accessible palettes.

[maxpou]

Does it need to be red?

I'd say yes since it is in the game.

@HSZemi I like the big cross but the light on the border looks odds (on without emulation). What do you think about this?

(different red + bigger cross + dark background)

[HSZemi]

I think the opaque red crosses look too aggressive – in my opinion, the visual focus should be on what's available, not on what's not

[simonsan]

Think so, too. I also personally don't see any problem with changing the colour to something that is easily distinguishable even if it's not red as in the game. It's nice to mimic in-game style, don't get me wrong. But accessibility would have higher priority for me. But only giving external thoughts here right. :)

[maxpou]

Agree with you, the red was too flashy. What do you think about this one? With a different red and card opacity.

Let me know if you're happy with the colours but don't merge the PR. There's a small issue when changing the civ (background don't get correctly reset).

[HSZemi]

I think adapting the background is the way to go :+1: It currently seems a bit too dark though.

[HSZemi]

Ok, radical proposal, I think this is the way (possibly with darkening the panel colour as well)

[HSZemi]

I think the opaque red crosses look too aggressive – in my opinion, the visual focus should be on what's available, not on what's not

I still think that is true in principle. However, the wooden cross just makes such a big difference when it comes to visual clarity that I believe it's a good step into the right direction.

Implemented in 135bfb636121447d8081cb3466b98261ef788ab6, I am closing this pull request for now, feel free to suggest further improvements :yellow_heart:

[maxpou]

Good job @HSZemi. Sorry if I completely forgot about this PR!