Update svgjs 3.1.1 - Githubissues

SiegeEngineers / aoe2techtree

Age of Empires II Tech Tree

https://aoe2techtree.net/

MIT License

225 stars 59 forks source link

Update svgjs 3.1.1 #102

Closed Rotzbua closed 2 years ago

Rotzbua commented 2 years ago

Update to latest svgjs version 3.1.1
Change cross to be more visible #100
- color taken from #101 + border for better detection
- increased size
Convert quotes to just single quotes

pardoman commented 2 years ago

Why convert quotes? adds changes everywhere, for no apparent benefit.

Rotzbua commented 2 years ago

Because mixed quotes are disturbing.

HSZemi commented 2 years ago

Many thanks for the pull request! :yellow_heart: For now I opted to use the wooden cross from DE instead of tinkering further with the svg cross to improve visibility. Therefore I excluded that change from your commits, and also fixed an issue with the quotation marks replacement that broke the stats display. The changes have been added in commits 45be01c279caf1d81e65a6fe35ccd047f1873520 and 0002a51a52ce78e4516ecc4d9cbc0f99017b3858