search

SiegeEngineers / aoe2techtree

Age of Empires II Tech Tree
https://aoe2techtree.net/
MIT License
225 stars 59 forks source link

Fix Japanese language tag #123

Closed Rotzbua closed 1 year ago

Rotzbua commented 1 year ago

Source: https://www.rfc-editor.org/rfc/bcp/bcp47.txt Page 79: Appendix A. Examples of Language Tags (Informative)

HSZemi commented 1 year ago

Looks like someone confused language code with country code there. Thanks! This breaks existing direct links that include lng=jp, so I hope nobody relies on that :kissing:

HSZemi commented 1 year ago

Ah, whoopsie. This breaks the site. The folder for the language files is also called jp. I knew I could blame Microsoft :upside_down_face: Reverted this for now.

Rotzbua commented 1 year ago

Thanks for the feedback. Seems I reloaded the online tab and not the localhost tab 🙈 .

The link language tags are right, but the actual URL uses the microsoft language tags. The problem is that the microsoft language tag is used for updating:

<html lang="">

I will provide a suitable patch when I have time again this week.