search

SiegeEngineers / aoe2techtree

Age of Empires II Tech Tree
https://aoe2techtree.net/
MIT License
226 stars 59 forks source link

Suggestions for Language switcher #56

Closed lalitpatel closed 3 years ago

lalitpatel commented 4 years ago

Related to #48

Three suggestions:

  1. We can either keep below the credits section;
  2. Or, on the top right if we chose it to be short switcher;
  3. Else at the bottom if we want a more descriptive one.

image

The drop-downs on the tech tree have fixed positions sample

HSZemi commented 4 years ago

How do those look on mobile? While we are not targeting mobile devices specifically, it would be nice if they could at least have access to all features.

lalitpatel commented 4 years ago

LGTM on mobile

mobile

pardoman commented 4 years ago

I'll grab whichever you want @HSZemi , thou I like the top-right one.

HSZemi commented 4 years ago

Ok, so I would prefer it to be in the left sidebar. After all, that is a setting that you use once at most, so it does not have to be accessible all the time. Sadly, that takes away from the precious vertical space in the sidebar. I guess we would have to sacrifice at least the key for it.

The bottom one has positioning issues, overlapping with the left sidebar on mobile and with the scrollbar on desktop. grafik

The top right version looks least obtrusive currently, but as stated, there is no need to have it visible all the time.

HSZemi commented 3 years ago

We have a working language switcher now, so I am closing this pull request. Thank you for putting in the effort and creating a part of it :yellow_heart: