SiegeEngineers / aoe2techtree

Age of Empires II Tech Tree
https://aoe2techtree.net/
MIT License
226 stars 59 forks source link

Fix/de building ordering #59

Closed MangelWare closed 4 years ago

MangelWare commented 4 years ago

Resolves #46.

I am a quite frequent user of aoe2techtree.net, and therefore saw my chance to contribute when I found the issue.

For the reorderings, I moved the lane pushes in getDefaultTree() around.

I added the Konnik and Elite Konnik as permanent Carets under the Krepost, as unavailable unique units (e.g. Genitour) usually are not invisible (like in DE), but disabled. This also avoids any ID conflicts, as the Konnik and Elite Konnik are else only used with the UNIQUE_UNIT and ELITE_UNIQUE_UNIT ID respectively within the castle lane. Hope this is a reasonable solution.

Additionally to the mentioned issues, I found that the Farm is located to the right of the Mill Upgrades, opposing to the original DE Tech tree, where it is located inbetween the Market lane and the mentioned upgrades:

AoE2TechTree-Farm-Placement

I also changed this by moving the Farm lane accordingly.

Hope you are happy with the changes! Let me know if something could be done better!

HSZemi commented 4 years ago

Thank you for working on this!

There are three things that could still be addressed:

MangelWare commented 4 years ago

Must have overlooked the Siege Workshop one in the issue. Will update all of the mentioned issues tomorrow. Thanks for the instant feedback!

MangelWare commented 4 years ago

Done!

HSZemi commented 4 years ago

Marvellous, thank you! :yellow_heart: