search

SiegeEngineers / aoe2techtree

Age of Empires II Tech Tree
https://aoe2techtree.net/
MIT License
227 stars 59 forks source link

Add localization #74

Closed nico2che closed 3 years ago

nico2che commented 4 years ago

one more try

thanks to @lalitpatel for the switcher and @pardoman for the data

Todo, after of during this PR

HSZemi commented 4 years ago

Looks alright! Dark Age and Xolotl Warrior seem to be missing proper translations still, but that should be fixable.

There is an issue with the civ grid in the advanced stats though: Every time you switch the language, it gets longer :see_no_evil: grafik

nico2che commented 3 years ago

thx for your feedback, I fixed it by moving createXRefBadges(); on init

I'll update my op with more details

HSZemi commented 3 years ago

Looks good! You should be able to run scripts/generateDataFiles.py to fix the missing strings in the language files.

I would say once those are updated we can merge this, and then think about whether we want to translate the tech tree specific strings in the extra stats as well, and if so, how.

HSZemi commented 3 years ago

I just ran the script again myself to update the data, and then merged this manually. Thank you for picking up this long-lived topic :yellow_heart:

nico2che commented 3 years ago

Thank you for your help, I didn't have access to the game to generate data