search

SiegeEngineers / aoe2techtree

Age of Empires II Tech Tree
https://aoe2techtree.net/
MIT License
225 stars 59 forks source link

Proposal to fix issue #94 #95

Closed mortis0 closed 3 years ago

mortis0 commented 3 years ago

Sort civ dropdown according to the language modified: js/main.js

HSZemi commented 3 years ago

Instead of first filling the select element with options, then reordering the options, it is easier to sort the data by the localised names first, then fill the select element. Which is what I implemented in eb779b3c8a2ac26f22c219adaa08f0fce33f2d38 – should be less code and less DOM restructuring. Thank you however for implementing a fix for your proposal as well! :yellow_heart: