SiegeLord / Tango-D2

A port of the Tango library to D2
http://siegelord.github.com/Tango-D2/
Other
90 stars 38 forks source link

Fix compiling with DMD 2.070.0-b1 #91

Closed jacob-carlborg closed 8 years ago

SiegeLord commented 8 years ago

Should we wait until https://issues.dlang.org/show_bug.cgi?id=15555 is resolved? Also, perhaps it's easy to make this compile with both 2.069 and 2.070?

jacob-carlborg commented 8 years ago

Should we wait until https://issues.dlang.org/show_bug.cgi?id=15555 is resolved?

Yes, that's a good idea. I created this PR before I created the bug report.

Also, perhaps it's easy to make this compile with both 2.069 and 2.070?

I'm not so sure, without using some form of static if. As far as I can see it, either Throwable will have a method called message or it won't. If it have the method, there are two possible solutions:

Both of these changes require that the message method is available in Throwable.

I guess a third option would be to change the name of the method in Tango. Hmm, renaming the method does not require any additional changes, but that would be a breaking change. Not sure how important that is though. We would also need to come up with a new name as well.

jacob-carlborg commented 8 years ago

The change that introduced the regression has been reverted: https://github.com/D-Programming-Language/druntime/pull/1469. Closing.