search

Sienci-Labs / gsender

Connect to and control Grbl-based CNCs with ease
https://sienci.com/gsender/
Other
188 stars 45 forks source link

Fixes for SO5 #454

Closed GibsT closed 9 months ago

GibsT commented 9 months ago

Strips inline comments from being sent to the serial port which will lock up a SO5. SO5 PID was added to the valid PID list.

kglovern commented 9 months ago

This is just the equivalent fix for bracket comments on Shapeoko firmware as https://github.com/Sienci-Labs/gsender/pull/450 with the PID added? We'll likely merge this in for next build instead of that one.

GibsT commented 9 months ago

This is just the equivalent fix for bracket comments on Shapeoko firmware as #450 with the PID added? We'll likely merge this in for next build instead of that one.

Yes it is.

gsrunion commented 9 months ago

Yep. I have been meaning to close my PR. When would these changes be available on a build, edge or otherwise?

kglovern commented 9 months ago

This is live as of 1.4.1, thank you both for your contributions.