Closed AustinoBombino closed 1 year ago
Merging #3305 (ae2be53) into master (cff3bb8) will decrease coverage by
0.05%
. The diff coverage is4.65%
.
@@ Coverage Diff @@
## master #3305 +/- ##
==========================================
- Coverage 42.09% 42.03% -0.06%
==========================================
Files 164 164
Lines 15547 15590 +43
==========================================
+ Hits 6544 6553 +9
- Misses 8600 8636 +36
+ Partials 403 401 -2
Impacted Files | Coverage Δ | |
---|---|---|
x/margin/keeper/legacy.go | 24.71% <0.00%> (-0.87%) |
:arrow_down: |
x/margin/keeper/migrations.go | 20.00% <0.00%> (+20.00%) |
:arrow_up: |
x/margin/keeper/msg_server.go | 56.48% <0.00%> (-0.88%) |
:arrow_down: |
x/margin/types/msgs.go | 29.46% <0.00%> (-2.47%) |
:arrow_down: |
x/margin/keeper/params.go | 78.16% <100.00%> (+0.51%) |
:arrow_up: |
@timlind @canercandan @Jedi2002 added a toggle parameter and tx
@AustinoBombino nice thanks for working on this, I believe we should add a migration handler as well to set the default value for this new toggle correct?
@AustinoBombino nice thanks for working on this, I believe we should add a migration handler as well to set the default value for this new toggle correct?
@canercandan Yup, fixed the tests and added a migrator
reenable rowan collateral for testing on staging
New TX form:
sifnoded tx margin update-rowan-collateral --enabled=true/false