Sifchain / sifnode

SifNode - The future of Defi
Other
108 stars 118 forks source link

feat: dynamic propsal fee #3361

Closed timlind closed 1 year ago

canercandan commented 1 year ago

@timlind Test scenarios as described in the test plan are all successful: https://www.notion.so/sifchain/Testplan-Release-v1-0-15-beta-Asymmetric-Adds-275b1c9195e1492a83a6050a4bcbe70b#20701f3332fa49078392374be69eb4c6

there is unit test that seems to fail though, if you can have a look and fix it thanks.

codecov[bot] commented 1 year ago

Codecov Report

Merging #3361 (1a40659) into master (e1c1daa) will decrease coverage by 0.03%. The diff coverage is 31.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3361      +/-   ##
==========================================
- Coverage   42.90%   42.86%   -0.04%     
==========================================
  Files         164      164              
  Lines       15727    15769      +42     
==========================================
+ Hits         6747     6759      +12     
- Misses       8573     8603      +30     
  Partials      407      407              
Impacted Files Coverage Δ
app/setup_handlers.go 8.69% <0.00%> (-0.40%) :arrow_down:
x/admin/keeper/grpc_query.go 22.22% <0.00%> (-6.35%) :arrow_down:
x/admin/keeper/msg_server.go 5.88% <0.00%> (-2.46%) :arrow_down:
x/admin/types/keys.go 100.00% <ø> (ø)
x/admin/types/msgs.go 0.00% <0.00%> (ø)
x/admin/keeper/keeper.go 74.35% <57.14%> (-3.77%) :arrow_down:
app/ante/ante.go 78.04% <87.50%> (+2.74%) :arrow_up:
app/app.go 90.10% <100.00%> (+0.02%) :arrow_up: