Umbrella header does not include a variety of header files

[ghost]

Installing through SPM I see about 15 warnings regarding the public headers.

Could these be included? This messes with projects that treat warnings as errors.

/Users/AnyUser/Library/Developer/Xcode/DerivedData/AnyProject/SourcePackages/checkouts/sift-ios/Sift/Sift.h:179:1: warning build: Umbrella header for module 'Sift' does not include header 'SiftCircularBuffer.h'

/Users/AnyUser/Library/Developer/Xcode/DerivedData/AnyProject/SourcePackages/checkouts/sift-ios/Sift/Sift.h:179:1: warning build: Umbrella header for module 'Sift' does not include header 'NSData+GZIP.h'

/Users/AnyUser/Library/Developer/Xcode/DerivedData/AnyProject/SourcePackages/checkouts/sift-ios/Sift/Sift.h:179:1: warning build: Umbrella header for module 'Sift' does not include header 'SiftEvent+Private.h'

/Users/AnyUser/Library/Developer/Xcode/DerivedData/AnyProject/SourcePackages/checkouts/sift-ios/Sift/Sift.h:179:1: warning build: Umbrella header for module 'Sift' does not include header 'SiftIosAppState.h'

/Users/AnyUser/Library/Developer/Xcode/DerivedData/AnyProject/SourcePackages/checkouts/sift-ios/Sift/Sift.h:179:1: warning build: Umbrella header for module 'Sift' does not include header 'SiftIosDeviceProperties.h'

/Users/AnyUser/Library/Developer/Xcode/DerivedData/AnyProject/SourcePackages/checkouts/sift-ios/Sift/Sift.h:179:1: warning build: Umbrella header for module 'Sift' does not include header 'Sift+Private.h'

/Users/AnyUser/Library/Developer/Xcode/DerivedData/AnyProject/SourcePackages/checkouts/sift-ios/Sift/Sift.h:179:1: warning build: Umbrella header for module 'Sift' does not include header 'SiftQueue.h'

/Users/AnyUser/Library/Developer/Xcode/DerivedData/AnyProject/SourcePackages/checkouts/sift-ios/Sift/Sift.h:179:1: warning build: Umbrella header for module 'Sift' does not include header 'SiftDebug.h'

In file included from <module-includes>:1:
/Users/AnyUser/Library/Developer/Xcode/DerivedData/AnyProject/SourcePackages/checkouts/sift-ios/Sift/Sift.h:179:1: warning build: Umbrella header for module 'Sift' does not include header 'SiftUploader.h'

/Users/AnyUser/Library/Developer/Xcode/DerivedData/AnyProject/SourcePackages/checkouts/sift-ios/Sift/Sift.h:179:1: warning build: Umbrella header for module 'Sift' does not include header 'SiftIosAppStateCollector+Private.h'

/Users/AnyUser/Library/Developer/Xcode/DerivedData/AnyProject/SourcePackages/checkouts/sift-ios/Sift/Sift.h:179:1: warning build: Umbrella header for module 'Sift' does not include header 'SiftUtils.h'

/Users/AnyUser/Library/Developer/Xcode/DerivedData/AnyProject/SourcePackages/checkouts/sift-ios/Sift/Sift.h:179:1: warning build: Umbrella header for module 'Sift' does not include header 'SiftIosAppStateCollector.h'

/Users/AnyUser/Library/Developer/Xcode/DerivedData/AnyProject/SourcePackages/checkouts/sift-ios/Sift/Sift.h:179:1: warning build: Umbrella header for module 'Sift' does not include header 'SiftIosDevicePropertiesCollector.h'

/Users/AnyUser/Library/Developer/Xcode/DerivedData/AnyProject/SourcePackages/checkouts/sift-ios/Sift/Sift.h:179:1: warning build: Umbrella header for module 'Sift' does not include header 'SiftHtDictionary.h'

/Users/AnyUser/Library/Developer/Xcode/DerivedData/AnyProject/SourcePackages/checkouts/sift-ios/Sift/Sift.h:179:1: warning build: Umbrella header for module 'Sift' does not include header 'SiftTokenBucket.h'

[vincent-sift]

@rodrigordc thanks for bringing this to our attention. We will address these issues and update this issue when we have an update. Thanks again :)

[michaeltaverne]

Seeing the same thing, would appreciate a fix. Thanks!

[samsiner]

I think this is the same or similar issue (Xcode 14.2). Would appreciate a fix:

[afanaian01]

Any update on this issue?

[viaskal-sift]

@afanaian01 could you pls check if this is still the case in the latest version? Thanks!

[afanaian01]

@afanaian01 could you pls check if this is still the case in the latest version? Thanks!

Yes. We can close this.

[mthormann-dhi]

This is still happening in Sift 2.1.2 on Xcode 14.3.1. Unless I'm missing something I don't think anything is fixed.

[viaskal-sift]

@mthormann-dhi hi, could you pls try the latest version (2.1.5) and let us know if you still have the issue?

[mthormann-dhi]

Yeah still seeing it on release configuration builds. Opened project, cleaned build folder, then did an archive. Not seeing on debug builds though. (edit: Xcode 15.0)

[viaskal-sift]

noted, I will reopen the issue then

[afanaian01]

We're seeing this again. Xcode 15.4 - sift 2.1.8

[lobotony]

Still getting this with Xcode 15.3 and SDK 2.2.1. The issue is easy to reproduce if you wrap the Sift SDK inside a Swift library package. We're suppressing the warnings for with with swiftSettings: [.unsafeFlags(["-suppress-warnings"])], but I'd prefer if you'd take care of it in the SDK. Thanks!

[apolwork]

@afanaian01, @lobotony

Could you try this PR (https://github.com/SiftScience/sift-ios/pull/153). It should resolve your issues with Umbrella headers