search

SiftScience / sift-ios

Sift iOS SDK
MIT License
19 stars 24 forks source link

Swift package manager tag naming convention #115

Open jrief-digikey opened 1 year ago

jrief-digikey commented 1 year ago

The Xcode Swift package manager seems to prefer tags of the form X.X.X (i.e. 2.1.1). Can an additional tag be added to the release to support Xcode?

viaskal-sift commented 1 year ago

Thanks @jrief-digikey for bringing this, we'll take a look

SujishaExalture commented 1 year ago

We cannot add additional tags. The version rule requires Swift packages to conform to semantic versioning . The Xcode Swift package manager should be tags of the form X.X.X (i.e. 2.1.1).

A package version is a three period-separated integer, for example 1.0.0. It must conform to the semantic versioning standard in order to ensure that your package behaves in a predictable manner once developers update their package dependency to a newer version. To learn more about the semantic versioning standard, visit https://semver.org

jrief-digikey commented 1 year ago

@SujishaExalture Agreed, Xcode is requiring tags following the semver standards, however Sift is preceding tags with a "v". I'm recommending that Sift drop the preceding "v".

SujishaExalture commented 1 year ago

Thanks for the catch. @jrief-digikey . We will consider for sure

jordanhbuiltbyhq commented 1 year ago

I had to select the master branch because of this issue, up to next major version doesn't work.

andrewjmeier commented 2 weeks ago

Hey @SujishaExalture can we get an update on this?