SiftScience / sift-ios

Sift iOS SDK
MIT License
19 stars 25 forks source link

Sift does not compile in Xcode 14.3 RC - file not found #118

Closed jordanhbuiltbyhq closed 1 year ago

jordanhbuiltbyhq commented 1 year ago

Trying to run our app on the Simulator in Xcode 14.3 RC shows this buildtime error:

File not found: /Applications/Xcode14.3.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/arc/libarclite_iphonesimulator.a

Looking into it I can see there is no arc folder there in Xcode 14.3 unlike Xcode 14.2.

Note we integrated Sift (2.1.1) via CocoaPods. Our app's deployment target is iOS 16. Using macOS Ventura 13.2.1.

Screenshot 2023-03-23 at 1 32 17 PM

If after running pod install you upgrade to the recommended project settings, it seems to resolve this issue, however issue #116 returned:

/.../Pods/Target Support Files/Sift/Sift-umbrella.h:13:9 double-quoted include "SiftCompatibility.h" in framework header, expected angle-bracketed instead

dineybomfim commented 1 year ago

Everybody with the newst Xcode seems to be blocked from even generating archives due to it... so we're blocked on TestFlight and AppStore. Need to release a new app version but can't until this is fixed.

viaskal-sift commented 1 year ago

@jordanhbuiltbyhq @dineybomfim sorry for the delay, we are already taking a look at the issue, so hopefully will introduce a fix soon

viaskal-sift commented 1 year ago

@jordanhbuiltbyhq @dineybomfim is the issue is still valid? cc @SujishaExalture

jordanhbuiltbyhq commented 1 year ago

Testing with Sift 2.1.2 in Xcode 14.3.1 I can confirm this issue still remains.

  1. pod install
  2. Run the app In the sidebar under Sift you see: Error: File not found: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/arc/libarclite_iphonesimulator.a Warning: /Users/Jordan/Developer/AppName/Pods/Pods.xcodeproj The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 11.0 to 16.4.99. Error: Linker command failed with exit code 1 (use -v to see invocation)
  3. Click the "Update to recommended settings" warning
  4. Click Perform Changes
  5. Run the app 8 errors appear: Screenshot 2023-07-12 at 9 15 31 AM

Note if you deselect "Target 'Sift' - Enable Module Verifier" and leave the other 3 Sift items selected (and all other items for other dependencies) then it works without issue.

SujishaExalture commented 1 year ago

@jordanhbuiltbyhq The minimum deployment target we set to 12 for SIFT 2.12. With Xcode 14.3 , No such build errors . We will check with 14.3.1 also and will update soon.

Screenshot 2023-07-13 at 2 19 44 PM
jordanhbuiltbyhq commented 1 year ago

Following the steps the minimum deployment is not 12.0 it's 8.0. It's in your Podspec.

Screenshot 2023-07-13 at 10 33 42 AM
viaskal-sift commented 1 year ago

@jordanhbuiltbyhq is it solved in the latest version (2.1.5)?

jordanhbuiltbyhq commented 1 year ago

Yes thank you