SiftScience / sift-python

Sift API (Python client)
MIT License
20 stars 23 forks source link

Failing to install package on python 3.12.0 #102

Closed camerongraybill closed 8 months ago

camerongraybill commented 1 year ago

I think the issue is for using imp in setup.py which was removed in python 3.12 https://docs.python.org/3.12/whatsnew/3.12.html#imp

~/sift_venv$ ./bin/pip install "sift (==5.5.0)"
Collecting sift==5.5.0
  Using cached Sift-5.5.0.tar.gz (12 kB)
  Preparing metadata (setup.py) ... error
  error: subprocess-exited-with-error

  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [6 lines of output]
      Traceback (most recent call last):
        File "<string>", line 2, in <module>
        File "<pip-setuptools-caller>", line 34, in <module>
        File "/tmp/pip-install-xtshbox0/sift_c6e85dc1a1cd46e1b7c97cadb428977a/setup.py", line 1, in <module>
          import imp
      ModuleNotFoundError: No module named 'imp'
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

~/sift_venv$ ./bin/python --version
Python 3.12.0

~/sift_venv$ ./bin/pip --version
pip 23.2.1 from ~/sift_venv/lib/python3.12/site-packages/pip (python 3.12)