SiftScience / sift-python

Sift API (Python client)
MIT License
20 stars 23 forks source link

Add support for Sift Science's version-204 API. #48

Closed jburnim closed 8 years ago

jburnim commented 8 years ago

This PR:

@nickhurlburt -- could you please review these changes?

cc @atpaino , @fredsadaghiani , @yschatzberg

jburnim commented 8 years ago

Looks like test discovery was not added to the unittest module until Python 2.7. I'll investigate switching to unittest2 or only running the tests under 2.6 and 3.4.

nickhurlburt commented 8 years ago

LGTM. What are your current thoughts on supporting Python 2.6 with respect to unit tests?

jburnim commented 8 years ago

What are your current thoughts on supporting Python 2.6 with respect to unit tests?

I updated the Travis testing config to use unittest2. Tests now pass for Python 2.6, 2.7, and 3.4: https://travis-ci.org/SiftScience/sift-python/builds/144594468 .

nickhurlburt commented 8 years ago

Awesome! Looks ready to go, then.

jburnim commented 8 years ago

cc @aaronTufts

jburnim commented 8 years ago

@nickhurlburt , @aaronTufts -- I updated this PR to add support for the return_worfklow_status Events API parameter, as well as the Workflow Status API, User Decisions API, and Order Decisions API.

nickhurlburt commented 8 years ago

Should workflow and decision methods have unit tests?

jburnim commented 8 years ago

Should workflow and decision methods have unit tests?

Tests have been added.

nickhurlburt commented 8 years ago

Still LGTM, thanks!