Closed jburnim closed 8 years ago
Looks like test discovery was not added to the unittest
module until Python 2.7. I'll investigate switching to unittest2
or only running the tests under 2.6 and 3.4.
LGTM. What are your current thoughts on supporting Python 2.6 with respect to unit tests?
What are your current thoughts on supporting Python 2.6 with respect to unit tests?
I updated the Travis testing config to use unittest2. Tests now pass for Python 2.6, 2.7, and 3.4: https://travis-ci.org/SiftScience/sift-python/builds/144594468 .
Awesome! Looks ready to go, then.
cc @aaronTufts
@nickhurlburt , @aaronTufts -- I updated this PR to add support for the return_worfklow_status
Events API parameter, as well as the Workflow Status API, User Decisions API, and Order Decisions API.
Should workflow and decision methods have unit tests?
Should workflow and decision methods have unit tests?
Tests have been added.
Still LGTM, thanks!
This PR:
abuse_type
,abuse_types
, andreturn_workflow_status
.@nickhurlburt -- could you please review these changes?
cc @atpaino , @fredsadaghiani , @yschatzberg