search

SiftScience / sift-python

Sift API (Python client)
MIT License
20 stars 23 forks source link

Don't depend on requests #52

Closed cdman closed 3 years ago

cdman commented 8 years ago

Or at least clearly document this dependency :smile:.

requests is complicated to use on Google Appengine since it requires either having a paid account and activating the socket service or using the requests_toolbelt package. See:

Alternatively, if sift-python would use libraries which come with the standard library (urllib2 / urllib.request), it would make it easier to use.

quanpod commented 7 years ago

Hi @cdman apologies for the long delay here - we're taking a look. If you've worked around this in the meantime and have updated suggestions, I'd love to hear it.

cdman commented 7 years ago

@quanpod - I'm using request_toolbelt (PyPi - docs - GitHub) for now (also, because other libraries we use depend on requests), however it has been far from smooth sailing (https://github.com/requests/toolbelt/issues?utf8=%E2%9C%93&q=is%3Aissue%20AppEngine).

IMHO, given the nature of the library, I really think it should only depend on things shipped with Python. But that's just my 2c :-)