SiftScience / sift-react-native

React Native Wrapper for Sift iOS and Android SDKs
MIT License
1 stars 12 forks source link

`setSiftConfig` required arguments #3

Open bell-steven opened 3 years ago

bell-steven commented 3 years ago

The Readme indicates that only the first two arguments, accountId and beaconKey, are required.

When running in my app, I am receiving native code errors indicating that all the parameters are indeed required.

Steps to reproduce:

npm install sift-react-native
cd ios && pod install && cd ..
// App.js
import React from 'react';
import SiftReactNative from 'sift-react-native';

const accountId = SIFT_SCIENCE_ACCOUNT_ID
const beaconKey = SIFT_SCIENCE_BEACON_KEY

const ConfigurationScreen = () => {
  ...
  SiftReactNative.setSiftConfig(
      accountId,
      beaconKey
    );
  ...
  return <View><Text>Hello Word</Text></View>
}

export default ConfigurationScreen;
TomSwift commented 2 years ago

Same. Looking at the implementation, we can pass an empty string for serverUrlFormat, but all params are strictly required by the typings.

16francej commented 2 years ago

Following up on this. The note in the README is unclear. Is it describing the endpoints in: https://sift.com/developers/docs/curl/device-fingerprinting-api/overview?