search

SiftScience / sift-react-native

React Native Wrapper for Sift iOS and Android SDKs
MIT License
1 stars 12 forks source link

`setPageName` type + iOS no-op method #6

Open jarredt opened 2 years ago

jarredt commented 2 years ago

The new setPageName method was not added to the Typescript types. Also, it would be ideal to add a no-op method for this on the iOS side, so that our own source code doesn't need to do platform-specific branching. Thanks!

vincent-sift commented 1 year ago

Thanks @jarredt we are aware of this issue and we are working on adding a fix.

mdole commented 1 year ago

Hey, we also use this package over at Artsy and would appreciate these changes as well! Are you accepting PRs from outside collaborators at the moment? If so, happy to throw one together

richardkuiper commented 9 months ago

Thanks @jarredt we are aware of this issue and we are working on adding a fix.

Hi @vincent-sift . Just checking if you are still working on this? Seems to be about a year and a half.

viaskal-sift commented 6 months ago

@mdole regarding

Are you accepting PRs from outside collaborators at the moment? If so, happy to throw one together

if you are still ready to raise a PR, feel free to do that