search

SigNoz / charts

Helm Charts for SigNoz
MIT License
63 stars 67 forks source link

support for scraping metrics from pods using annotations #196

Open prashant-shahi opened 1 year ago

prashant-shahi commented 1 year ago

There can be two scrapers using one prometheus receiver: external.signoz.io/scrape and prometheus.io/scrape. The first one being enabled by default, while the second one optionally enabled using preset configuration.

srikanthccv commented 1 year ago

while the second one optionally enabled using preset configuration

Make this enabled by default and give the option to disable it. Users really like it when the collection is done automatically.

prashant-shahi commented 1 week ago

Make this enabled by default and give the option to disable it. Users really like it when the collection is done automatically.

@srikanthccv Are you sure about this? If they have lots of pods with prometheus pod scraping enabled, this could potentially cause lots of unintended metrics scraping and cost as well in cloud.

In the above PR, I have disabled by default. If we are okay with the collection, we can enable it by default.