search

SigNoz / charts

Helm Charts for SigNoz
MIT License
75 stars 76 forks source link

otel-agent: varlibdockercontainers is not always relevant #379

Open zimbatm opened 9 months ago

zimbatm commented 9 months ago

https://github.com/SigNoz/charts/blob/7e7b159809d0659d75631d65a88e3734a3f7218d/charts/k8s-infra/templates/otel-agent/daemonset.yaml#L118-L122

This option should probably be globally configurable. Depending on your K8s installation, Docker is not present on the host (eg: RKE2).

grandwizard28 commented 1 week ago

Hi @zimbatm, Thanks for opening this issue! Would you be willing to contribute a PR for the same?