search

SigNoz / charts

Helm Charts for SigNoz
MIT License
77 stars 80 forks source link

SMTP configuration #443

Open pascal89 opened 6 months ago

pascal89 commented 6 months ago

Hi, Currently, the Signoz Helm chart doesn't support providing the SMTP configuration explicitly. By looking into the Helm chart I already found out, I'll be able to configure this via the queryService.additionalEnvs chart variable, but that way I'll unfortunately have to provide my SMTP password in an unsecure way.

My suggestion is to update the Helm chart to be able to provide the SMTP configuration through Helm variables, where for the SMTP password we'll be able to provide this through an existing secret.

As I have experience with maintaining Helm charts, and I'm also willing to make a contribution for this. Please let me hear your thought on this.

pascal89 commented 5 months ago

Hi @prashant-shahi, do you have any comments on this? Thanks in advance :-)

grandwizard28 commented 2 months ago

Hi @pascal89, That sound nice! Would you be willing to open a PR?

pascal89 commented 2 months ago

Sure, I'll add it to my planning. I'll probably be able to pick it up in a few weeks from now.

prashant-shahi commented 2 months ago

@pascal89 That would be great. Looking forward for your contribution.