SigNoz / charts

Helm Charts for SigNoz
MIT License
75 stars 76 forks source link

Should we set global.registry to all componts #493

Open dmsolr opened 1 month ago

dmsolr commented 1 month ago

I found some components set a hard code 'docker.io' as registry, should we set them to global.registry?

grandwizard28 commented 1 month ago

Hi @dmsolr, Which components are you referring to?

dmsolr commented 2 weeks ago

Here is an example, https://github.com/SigNoz/charts/blob/9b995e16f4b6f9e4adcfae7081470b9c3c43e870/charts/signoz/values.yaml#L598-L603 This is a self-hosted component, the query service, and many components, such as initContainers, use docker.io as the image repository.