prashant-shahi
commented
1 month ago Can you bump up chart version as well?
Closed srikanthccv closed 1 month ago
prashant-shahi
commented
1 month ago Can you bump up chart version as well?
srikanthccv
commented
1 month ago I will bump when all individual PRs are merged.
https://github.com/SigNoz/charts/pull/523 https://github.com/SigNoz/charts/pull/521 https://github.com/SigNoz/charts/pull/516
coderabbitai[bot]
commented
1 month ago The pull request introduces significant updates to the configuration templates and values for the OpenTelemetry Collector in Kubernetes. Key modifications include the addition of new metrics configurations, enhancements to conditional logic for applying configurations, and refined handling of service pipelines. The values.yaml file has also been updated to reflect new metrics, an image tag upgrade, and improved resource detection. These changes collectively enhance the flexibility and robustness of the OpenTelemetry setup.
| File Path | Change Summary |
|---|---|
| charts/k8s-infra/templates/_config.tpl | - Added metrics field to clusterMetricsConfig, kubeletMetricsConfig, and logsCollectionConfig.- Enhanced conditional logic for applying configurations based on presets. - Refined service pipeline handling to unset empty receivers/exporters. - Standardized exporters configuration across services. - Improved resource detection and deployment environment configurations. - General refactoring for clarity. |
| charts/k8s-infra/values.yaml | - Expanded clusterMetrics with new node conditions and metrics.- Updated image tags for otelAgent and otelDeployment to 0.109.0.- Defined clusterName in both global and K8s infra settings.- Maintained service configurations and RBAC rules. - Specified resource requests and limits for deployments. |
appVersion from 0.88.0 to 0.109.0, consistent with the version upgrade in the main PR.metrics field in the kubeletMetrics section, aligning with the new metrics configuration in the main PR.otelCollector image tag to 0.102.10, relevant to the image tag updates in the main PR.otelCollector image tag to 0.102.12, continuing the versioning updates seen in the main PR.In the fields of code, we hop and play,
New metrics bloom, brightening the day.
With tags that soar, our versions align,
OpenTelemetry shines, oh how divine!
Configs refined, like a rabbit's dance,
In Kubernetes gardens, we take our chance! 🐇✨
charts/k8s-infra/values.yaml (3)
`201-203`: **Excellent addition of new node conditions and metrics!** The inclusion of `DiskPressure`, `PIDPressure`, and `NetworkUnavailable` node conditions, along with the `k8s.node.condition` and `k8s.pod.status_reason` metrics, significantly enhances the cluster's observability. These additions will provide more comprehensive insights into the cluster's health and potential issues. Also applies to: 209-213 --- Line range hint `1-924`: **Summary of changes and their impact** This update brings two main improvements to the Kubernetes infrastructure setup: 1. Enhanced cluster metrics: New node conditions and metrics have been added, which will provide more detailed insights into the cluster's health and performance. 2. OpenTelemetry Collector version update: Both OtelAgent and OtelDeployment have been updated to version 0.109.0, which likely includes new features, bug fixes, and performance improvements. These changes should significantly improve the observability of your Kubernetes cluster. However, ensure that you've thoroughly tested the new version and reviewed any potential breaking changes before deploying to production. --- Line range hint `277-277`: **Approved: OpenTelemetry Collector version update** The update of the OpenTelemetry Collector image from version 0.88.0 to 0.109.0 for both OtelAgent and OtelDeployment is a significant upgrade. This likely brings important improvements and new features. Please ensure that: 1. This version is compatible with your current setup. 2. You've reviewed the changelog for any breaking changes or new features that may require configuration updates. 3. You've tested this version in a non-production environment before deploying to production. To assist with the verification, you can run the following script to check for any potential issues: Also applies to: 574-574✅ Verification successful
**** The OpenTelemetry Collector image has been successfully updated from version **0.88.0** to **0.109.0** in `charts/k8s-infra/values.yaml`. No remaining hardcoded references to the old version were found in the codebase. Please proceed with testing to ensure full compatibility and verify that all functionalities operate as expected.🏁 Scripts executed
The following scripts were executed for the analysis: Script: ```shell #!/bin/bash # Description: Check for potential compatibility issues with the new OpenTelemetry Collector version # Test: Search for custom configurations that might be affected by the version update echo "Searching for custom OpenTelemetry Collector configurations:" rg --type yaml 'otelcol|opentelemetry' -g '!charts/k8s-infra/values.yaml' # Test: Check if there are any hardcoded version references that need updating echo "Checking for hardcoded OpenTelemetry Collector version references:" rg --type yaml '0\.88\.0' -g '!charts/k8s-infra/values.yaml' echo "Please review these results and ensure all necessary updates have been made." ``` Length of output: 2259charts/k8s-infra/templates/_config.tpl (1)
`165-166`: **Ensure the 'metrics' field under 'k8s_cluster' receiver is correctly configured** The `metrics` field has been added under the `k8s_cluster` receiver. Please verify that the metrics specified in `.Values.presets.clusterMetrics.metrics` align with the expected configuration schema of the `k8s_cluster` receiver in the OpenTelemetry Collector. This ensures that only valid and supported metrics are collected without causing configuration errors.
Summary by CodeRabbit
New Features
Updates
Bug Fixes
Documentation