Closed srikanthccv closed 1 month ago
The changes in this pull request involve significant updates to the Helm templates and configuration files for the SigNoz application. Key modifications include the introduction of new functions for schema migrator and otelCollector components, adjustments to initialization processes, and the addition of roles, role bindings, and service accounts. The updates aim to enhance the structure and consistency of the Kubernetes configurations, particularly focusing on asynchronous operations and improved RBAC management.
File Path | Change Summary |
---|---|
charts/signoz/templates/_helpers.tpl | Added functions: schemaMigrator.roleName , schemaMigrator.roleBindingName , schemaMigrator.serviceAccountName , otelCollector.clusterRoleName , otelCollector.clusterRoleBindingName . Removed selector labels for init and upgrade jobs. |
charts/signoz/templates/otel-collector-metrics/deployment.yaml | Updated init container argument to -sync . Adjusted indentation for clarity. |
charts/signoz/templates/otel-collector/deployment.yaml | Renamed init container argument to -sync . Corrected indentation for imagePullPolicy . |
charts/signoz/templates/schema-migrator-async/migrations.yaml | Renamed Job to -async , simplified execution condition, updated labels, added ttlSecondsAfterFinished , and added new init container. |
charts/signoz/templates/schema-migrator-async/role.yaml | Introduced a new Role resource for schema migrator with dynamic naming and conditional creation. |
charts/signoz/templates/schema-migrator-async/rolebinding.yaml | Introduced a new RoleBinding resource with dynamic naming and conditional creation. |
charts/signoz/templates/schema-migrator-async/serviceaccount.yaml | Introduced a new ServiceAccount resource with dynamic naming and conditional creation. |
charts/signoz/templates/schema-migrator/migrations.yaml | Renamed Job to -sync , simplified creation condition, updated labels, added ttlSecondsAfterFinished , and modified service account name. |
charts/signoz/templates/schema-migrator/role.yaml | Introduced a new Role resource for schema migrator with dynamic naming and conditional creation. |
charts/signoz/templates/schema-migrator/rolebinding.yaml | Introduced a new RoleBinding resource with dynamic naming and conditional creation. |
charts/signoz/templates/schema-migrator/serviceaccount.yaml | Introduced a new ServiceAccount resource with dynamic naming and conditional creation. |
charts/signoz/values.yaml | Updated image tags and added configurations for service accounts, roles, and role bindings for schema migrator and otelCollector. |
Objective | Addressed | Explanation |
---|---|---|
Implement asynchronous schema migrations to avoid failures during data mutations. (#5433) | ✅ | |
Ensure that the collector can operate independently of the migrator's success. (#5433) | ✅ |
In the garden of code, we hop and play,
With roles and bindings, we pave the way.
Schema migrator, now swift and bright,
Asynchronous dreams take flight at night.
With every change, our templates sing,
A joyful dance, let the updates ring! 🐇✨
Fixes https://github.com/SigNoz/signoz/issues/5433
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Chores