Closed prashant-shahi closed 4 weeks ago
The pull request introduces changes to the Helm templates for Kubernetes Jobs associated with the schema migrator in the SigNoz application. A new variable, $schemaMigratorSuffix
, is defined to conditionally modify the Job name based on the installation context. The ttlSecondsAfterFinished
field is removed, affecting job retention. Additionally, annotations for Helm hooks are added to manage the lifecycle of the schema migrator during upgrades, ensuring it runs before the main upgrade and is deleted appropriately. The init containers are also renamed for clarity, and new containers are introduced to enhance functionality.
File Path | Change Summary |
---|---|
charts/signoz/templates/schema-migrator-async/migrations.yaml | - Updated Job name to include $schemaMigratorSuffix .- Modified command arguments to append the suffix. - Removed ttlSecondsAfterFinished .- Renamed init containers and added a new wait container. |
charts/signoz/templates/schema-migrator/migrations.yaml | - Updated Job name to include $schemaMigratorSuffix .- Adjusted init container names for clarity. - Removed ttlSecondsAfterFinished .- Reformatted command for the first init container. |
charts/signoz/values.yaml | - Added upgradeHelmHooks to enable lifecycle management.- Updated image tags for schemaMigrator and otelCollector .- Modified initContainers to include a new wait container. |
charts/signoz/templates/otel-collector-metrics/deployment.yaml | - Added conditional logic for init container arguments based on installation or upgrade context. |
charts/signoz/templates/otel-collector/deployment.yaml | - Introduced conditional logic for init container arguments depending on installation or upgrade context. |
🐇 In the garden of code, changes bloom,
A suffix to names, dispelling the gloom.
With hooks in the air, migrations take flight,
Jobs dance to the rhythm, all set for the night.
A sprinkle of YAML, a dash of delight,
In the world of SigNoz, everything's right! 🌼
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Summary
New Features
wait
init container to ensure ClickHouse readiness before migration.schemaMigrator
andotel-collector
based on installation or upgrade context.schemaMigrator
andotelCollector
to enhance deployment.Bug Fixes
Documentation
values.yaml
file to reflect new annotations and image version updates.