coderabbitai[bot]
commented
2 weeks ago Walkthrough
The pull request introduces modifications to the values.yaml file for the Kubernetes infrastructure chart, specifically enhancing the kubeletMetrics section by enabling multiple new metrics related to CPU and uptime for nodes, pods, and containers. Additionally, it addresses redundancy in the clusterName key within the global section, which appears twice as an empty string. The overall structure of the configuration remains unchanged aside from these additions.
Changes
| File Path | Change Summary |
|---|---|
| charts/k8s-infra/values.yaml | - Added new metrics under kubeletMetrics: k8s.node.cpu.usage, k8s.node.uptime, k8s.pod.cpu.usage, k8s.pod.uptime, container.cpu.usage, k8s.container.cpu_limit_utilization, k8s.container.cpu_request_utilization, k8s.container.memory_limit_utilization, k8s.container.memory_request_utilization, container.uptime (all set to enabled: true). - Noted redundancy in the clusterName key defined twice as an empty string. |
Possibly related PRs
- #500: This PR adds new metrics configurations in the
values.yamlfile, including CPU and memory utilization metrics, which are directly related to the new metrics introduced in the main PR. - #521: This PR enhances the
kubeletMetricssection invalues.yamlby adding new metrics, includingcontainer.uptimeandk8s.node.uptime, which are also included in the main PR. - #522: This PR introduces additional metrics for cluster metrics, which may relate to the overall enhancements in monitoring capabilities discussed in the main PR.
- #547: This PR adds new resource attributes for cluster metrics, which complements the new metrics introduced in the main PR, enhancing the overall monitoring capabilities.
Suggested reviewers
- prashant-shahi
🐇 In the fields where metrics grow,
New insights we shall sow.
Uptime, usage, all in sight,
Monitoring made just right!
With clarity, we’ll configure,
A Kubernetes world, we’ll rigor! 🌱
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
The k8s.{pod/node/container}.cpu.utilization metrics are deprecated in favor of k8s.{pod/node/container}.cpu.usage. However, they are not enabled by default. We start collecting early, so when the `.cpu. utilisation metrics are removed, we will have enough data backfilled. Add uptime and container req/limit metrics.
Summary by CodeRabbit
New Features
Bug Fixes
clusterNamekey to prevent potential configuration conflicts.