search

SigNoz / signoz-otel-collector

SigNoz distro for OpenTelemetry Collector
44 stars 39 forks source link

Can not specify a cluster name for Clickhouse #306

Closed chensunny closed 2 months ago

chensunny commented 5 months ago

Can not specify a cluster name for Clickhouse。

Since we're using a self-built Clickhouse cluster, the DBA will specify the appropriate name(such as default ). So we can not use the name cluster cluster

https://github.com/SigNoz/signoz-otel-collector/blob/49769fd8f39e7313d1729977e31b25ebf23d1a01/exporter/clickhouselogsexporter/exporter.go#L47C2-L47C9

image
srikanthccv commented 4 months ago

The constant you linked to is not used anywhere in the code.

srikanthccv commented 4 months ago

https://github.com/SigNoz/signoz-otel-collector/pull/307

srikanthccv commented 2 months ago

Specifying your own cluster name is supported.