search

SigNoz / signoz-otel-collector

SigNoz distro for OpenTelemetry Collector
45 stars 41 forks source link

Use --cluster instead of --cluster-name in migrator command flag #308

Closed git-hulk closed 5 months ago

git-hulk commented 6 months ago

Currently, the otel collector is using the --cluster-name to pass the ClickHouse name, but the signoz query component is using --cluster. See:

[1] https://github.com/SigNoz/signoz-otel-collector/blob/main/cmd/signozschemamigrator/migrate.go#L41 [2] https://github.com/SigNoz/signoz/blob/develop/pkg/query-service/main.go#L54

Not sure if it sounds good to add an extra --cluster to keep consistent with the query component, or add an extra option --cluster-name in the query component?

I will be happy to submit a PR to resolve this if it sounds good.

srikanthccv commented 6 months ago

Let's change the query service arg to --cluster-name.

git-hulk commented 6 months ago

@srikanthccv Thank you! Will do it soon.