search

SigNoz / signoz-otel-collector

SigNoz distro for OpenTelemetry Collector
44 stars 39 forks source link

chore: deprecate use of old columns in traces #321

Closed makeavish closed 3 months ago

makeavish commented 3 months ago

close: https://github.com/SigNoz/signoz-otel-collector/issues/42

srikanthccv commented 3 months ago

Did we ever directly communicate with the users via some notification that we are deprecating these? This change should be preceded by identifying the views/dashboards/alerts that used the deprecated columns and automatically migrating them as much as possible. Otherwise, I think this will lead to issues as it removes some top-level columns users might have used in the product.

makeavish commented 3 months ago

Did we ever directly communicate with the users via some notification that we are deprecating these? This change should be preceded by identifying the views/dashboards/alerts that used the deprecated columns and automatically migrating them as much as possible. Otherwise, I think this will lead to issues as it removes some top-level columns users might have used in the product.

We had a warning in our docs for a very long time: https://github.com/SigNoz/signoz.io/issues/764 Component attribute existed since opentracing so it wouldn't have any values. grpcCode, grpcMethod, httpCode, tagMap were not returned as an attribute so users wouldn't have used them in views/dashboard built with query builder. For clickhouse builder users had to read docs to know columns they can use and would have saw warnings.

Only concern might be externalHttpMethod and externalHttpUrl.