search

SigNoz / signoz-otel-collector

SigNoz distro for OpenTelemetry Collector
44 stars 39 forks source link

feat: add status message and spanKind in span #326

Closed nityanandagohain closed 3 months ago

nityanandagohain commented 3 months ago

Fixes https://github.com/SigNoz/signoz/issues/4925

stores

there will be a corresponding PR in QS as well.

srikanthccv commented 3 months ago

The title says span kind but there are no span kind related changes!

nityanandagohain commented 3 months ago

my bad I added spanKind but have removed it later and missed updating the title. have updated it now.

srikanthccv commented 3 months ago

span status code too should have a string https://github.com/SigNoz/signoz-otel-collector/pull/326/files#diff-4df6d5a5494873f31c05a280deecb61a8ceee3d0ba4244368fef2db019bcd9f2R368

nityanandagohain commented 3 months ago

@srikanthccv do you suggest mapping 

"status": {
        "status_code": "ERROR",
        "description": "Exception: hello"
    },

to statusCodeString and statusMessage respectively ? as of now we are just setting errorMessage when the statuscode is error, so we can remove errorMessage and instead store statusCodeString and statusMessage ?

srikanthccv commented 3 months ago

Sounds good to me.